[Visual] Compute bounding box in VisualMesh#5985
Open
alxbilger wants to merge 1 commit intosofa-framework:masterfrom
Open
[Visual] Compute bounding box in VisualMesh#5985alxbilger wants to merge 1 commit intosofa-framework:masterfrom
alxbilger wants to merge 1 commit intosofa-framework:masterfrom
Conversation
alxbilger
added
pr: enhancement
fredroy
requested changes
Mar 2, 2026
Contributor
fredroy
left a comment
fredroy
left a comment
There was a problem hiding this comment.
And should computeBBox() compute BBox if:
- computeOnlyVisible is true (meaning computeBBox was called for rendering)
- vparams->displayFlags().getShowVisualModels() is false ?
?
| } | ||
| } | ||
|
|
||
| void VisualMesh::computeBBox(const core::ExecParams* exec_params, bool cond) |
Contributor
There was a problem hiding this comment.
Suggested change
| void VisualMesh::computeBBox(const core::ExecParams* exec_params, bool cond) | |
| void VisualMesh::computeBBox(const core::ExecParams* exec_params, bool computeOnlyVisible) |
cond is not really.... informative 🫢
|
|
||
| void VisualMesh::computeBBox(const core::ExecParams* exec_params, bool cond) | ||
| { | ||
| if (!d_enable.getValue()) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!d_enable.getValue()) | |
| SOFA_UNUSED(computeOnlyVisible); | |
| if (!d_enable.getValue()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if